aio-libs / multidict / 37459251993

86%

push

github

Let the compiler decide inlining for the bulk update helpers (#1704)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `ALWAYS_INLINE`, `NOINLINE` and `inline` from the helpers only
`extend()`, `update()`, `merge()` and `__init__()` reach, leaving them
plain `static` so GCC decides. `_md_extend_self_scan()` keeps
`ALWAYS_INLINE`, and the `COLD` helpers are untouched. This is an
experiment to see what CodSpeed reports; GCC now keeps the per-item
`_md_update()`, `_md_merge()`, `md_add_for_upd()` and
`_md_update_item()` out of line, so update and merge may regress.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Helpers changed to plain `static`: `_multidict_extend_parse_args`,
`_multidict_clone_fast`, `md_reserve_batch`, `_md_rebuild_to_anystr`,
`md_extend_self`, `md_post_update`, `_md_post_update_deleted`,
`_md_update`, `_md_merge`, `_md_update_item`, `md_add_for_upd`,
`_md_add_for_upd_steal_refs`, `update_marks_init`, `update_marks_end`,
`update_marks_release`, `update_marks_sync`, `update_marks_doom`.

`.text` (sum of function symbols, GCC 15, release flags) vs master
580c2f0d: 239164 -> 206235 (3.14.7), 247958 -> 219405 (3.14.7t), 235397
-> 202240 (3.10.17).

No callgrind run on this exact change yet; CodSpeed is the measurement
asked for.

Tests: `pytest -q` on 3.14.... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line