aio-libs / multidict / 37452838129

86%

push

github

Fold _parse2_bind() into _parse2_slow(), drop ALWAYS_INLINE from _name_is() (#1698)

<!-- Thank you for your contribution! -->

## What do these changes do?

Folds `_parse2_bind()` into `_parse2_slow()`, its only caller. The cold
function used to call the binder through two out-parameters and then
copy
them into the returned `parse2_t`; now it fills that struct directly and
jumps to one `fail:` label on error. The three `_raise_*` helpers return
`void`, since nothing reads their result any more.

`_name_is()` drops `ALWAYS_INLINE` and `inline`. It is only used inside
the
cold function, and GCC inlines it there anyway.

With GCC, `_parse2_slow()` goes from 167 to 169 instructions on both GIL
and FT, and no other function changes its instruction count or call
targets. The positional fast path in `parse2()` is untouched.

Pure Python has no equivalent.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes a function.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change;
existing tests cover the keyword and error paths)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests (`pytest -q`, each leg in its own venv and tree copy): 3.14 GIL
4089
passed, 3.14t FT 4074 passed, 3.10 4093 passed, pure Python
(`MULTIDICT_NO_EXTENSIONS=1 --no-c-extensions`) 1610 passed.

`tools/check_inlining.py` on 3.14 and 3.14t: ok, 23 and 25 rules.

`tools/codegen_diff.py --ref 2db70d6b` (GCC 15): about 77 of 363
function... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line