aio-libs / multidict / 37454066506

86%

push

github

Call parse2() from the method slots, not from shared helpers (#1699)

<!-- Thank you for your contribution! -->

## What do these changes do?

Moves the `parse2()` call of `get()`, `getall()`, `getone()`, `add()`,
`setdefault()`, `pop()` and `popone()` out of the shared `ALWAYS_INLINE`
helpers and into each method slot (the MultiDict, CIMultiDict and
CIMultiDictProxy copies). The helpers now take the parsed key and
default (or value). `_multidict_getone_impl()` is dropped, since the
getone slots can call the existing `_multidict_getone()` directly.
`popall()` already parsed in its slot. The pure-Python backend is not
affected.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No. The `parse2()` call is repeated per slot, but each slot now shows
its own argument binding.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: C extension on 3.14.7 (4089 passed, 181 skipped) and 3.10.17
(4093 passed, 177 skipped); pure Python on 3.14.7 with
`--no-c-extensions` (1610 passed).

Inlining: `tools/check_inlining.py` ok on 3.14.7 (23 rules) and 3.14.7t
(25 rules).

Codegen: `tools/codegen_diff.py` against the merge base reports small
shifts in the touched slots (e.g. `multidict_add` 394 -> 371
instructions on GIL) and one unrelated function growing on FT
(`cimultidict_proxy_sq_contains` 396 -> 438, different call set), likely
an inlining budget shift. No callgrind measurement was taken yet.

</details>

Drafted... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line