aio-libs / multidict / 37449462066

86%

push

github

Move md_reserve() and md_reserve_batch() out of line (#1697)

<!-- Thank you for your contribution! -->

## What do these changes do?

Marks `md_reserve()` and `md_reserve_batch()` `NOINLINE`. Each runs once
per `extend()`, `update()` or `merge()` call, before the batch starts,
so the extra call is lost in the noise. `.text` shrinks by 3.2 KB on GIL
builds (3.10 and 3.14) and by 160 B on 3.14t.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

`benchmarks/callgrind_driver.py --include-multidict-only`,
`PYTHONHASHSEED=0`, base 2db70d6b vs this branch, equal-length tree and
venv paths, GCC 15. Every row not listed moved by 0 Ir. A base-to-base
control on a second tree was identical.

| build | impl | operation | Ir/op delta |
| --- | --- | --- | --- |
| 3.14.7 | MultiDict | getitem_istr | -8 (-1.10%) |
| 3.14.7 | MultiDict | setitem_istr | -10 (-1.17%) |
| 3.14.7 | CIMultiDict | popitem | +2 (+0.23%) |
| 3.14.7t | both | all | 0 |

`.text`: 244736 -> 241472 (3.14.7), 249936 -> 249776 (3.14.7t), 241968
-> 238672 (3.10.17). FT `Py_DECREF` and `_Py_NewRef` stay out of line,
as on master.

Tests: `pytest -q` on 3.14.7 (4089 passed), 3.14.7t (4074 passed) and
3.10.17 (4093 passed). `tools/check_inlining.py` passes on 3.14.7 and
3.14.7t. Pre-commit and `make doc-spelling` pass.
</details>

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line