aio-libs / multidict / 37446605083

86%

push

github

Move htkeys_pools_clear() and pool_clear() out of line (#1696)

<!-- Thank you for your contribution! -->

## What do these changes do?

Marks `htkeys_pools_clear()` and `pool_clear()` as `NOINLINE`, matching
their `*_init()` counterparts. They run only from `drain_pools()`, when
the module is cleared or `_freelist_clear()` is called. `drain_pools()`
is marked `NOINLINE` too: once its body shrinks GCC inlines it into both
callers, which grew GIL `.text` by 64 bytes.

With all three marked, GIL `.text` is the same size as on master (198880
bytes) and `drain_pools()` drops from 77 to 15 instructions.
`tools/codegen_diff.py` against the merge base reports no other change
on GIL apart from alignment padding in
`multidict_values_iter_tp_iternext` and `MultiDict_AddWatcher`, and 0 of
369 functions on FT, where nothing is pooled. No runtime path calls the
changed code, so there is no callgrind measurement.

Pure Python has no equivalent.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change;
existing module teardown and `_freelist_clear()` tests cover the path)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` on 3.14.7 C extension, 4089 passed, 181 skipped.
`pytest -q -m "not leaks and not hypothesis and not capi"` on 3.10.17 C
extension, 3913 passed. `MULTIDICT_NO_EXTENSIONS=1 pytest -q
--no-c-extensions` on 3.14.7, 1610 passed.
Inlining: `t... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line