aio-libs / multidict / 37445951547

86%

push

github

Drop redundant ALWAYS_INLINE from three helpers (#1695)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `ALWAYS_INLINE` and `inline` from `_bitmap_dense_test()`,
`_md_last_live()` and `_word_has_upper()`. The compilers inline all
three on their own, so the pins only add noise. `_md_last_live()` stays
covered by its existing `tools/check_inlining.py` rule.

These are the only three of the 93 `ALWAYS_INLINE` pins outside
`bulk_update.h` whose removal leaves the code unchanged on every
compiler tried; the other 90 change codegen on at least one build, so
they stay.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Disassembly byte-identical to master (2db70d6b) on 3.10.17, 3.14.7 and
3.14.7t with GCC 15, on 3.14.7 and 3.14.7t with GCC 13 (CI's compiler)
and with clang. MSVC not checked.

Tests: `pytest -q` on 3.14.7 (4089 passed), 3.14.7t (4074 passed) and
3.10.17 (4093 passed). `tools/check_inlining.py` passes on 3.14.7 and
3.14.7t. Pre-commit and `make doc-spelling` pass.
</details>

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line