aio-libs / multidict / 37430815526

86%

push

github

Drop inline from views.h and two bulk update helpers (#1691)

<!-- Thank you for your contribution! -->

## What do these changes do?

Makes every `static inline` function in `views.h` plain `static`, along
with `_md_post_update_deleted()` and `md_update_from_kwnames()` in
`bulk_update.h`. GCC ignores the hint for all of them: the extension is
byte-identical to master.

Clang does honor the hint: without it, clang moves `_set_add()` out of
`_itemsview_and()` and `_itemsview_unmatched()`, the view set
operations, and `.text` shrinks by 48 bytes on GIL and 80 on FT. Those
are not hot paths.

Pure Python has no equivalent.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Disassembly byte-identical to master on 3.10.17, 3.14.7 and 3.14.7t with
GCC 15, and on 3.14.7 and 3.14.7t with GCC 14. Clang (3.14.7, 3.14.7t)
differs only by the out-of-line `_set_add()`.

Tests: `pytest -q` on 3.14.7 (4089 passed) and 3.14.7t (4074 passed).
Pre-commit and `make doc-spelling` pass.
</details>

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line