aio-libs / multidict / 37430794540

86%

push

github

Drop inline and ALWAYS_INLINE from capsule.h (#1690)

<!-- Thank you for your contribution! -->

## What do these changes do?

Makes the three helpers in `capsule.h` plain `static`: `_md_new()` and
`_watcher_registered()` lose `inline`, and `_proxy_new()` loses
`ALWAYS_INLINE` and `inline`.

For `_md_new()` and `_watcher_registered()` the hint changed nothing;
the code is byte-identical without it. GCC still inlines `_proxy_new()`
into both `MultiDictProxy_New()` and `CIMultiDictProxy_New()` without
the attribute, with the constant `is_ci` folded. Dropping it changes
GCC's inlining budget, so a few unrelated functions are laid out
differently (`_str_borrow_identity_ci` and `_md_rebuild` on GIL,
`_md_update_from_seq_update` on FT), with no measurable effect; see
below.

Pure Python has no equivalent; this only touches the C API
implementation.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change;
`tests/test_capi.py` covers these paths)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

`.text`: GIL 245568 → 245504, FT 251440 → 251312, 3.10 unchanged (GCC
15).

Callgrind: `benchmarks/callgrind_driver.py --include-multidict-only`,
`PYTHONHASHSEED=0`, equal-length trees and venvs, 3.14.7 and 3.14.7t.
Every C row is within ±0.1%: the largest are FT `update` (−40 Ir,
−0.09%) and GIL `setitem_istr` on MultiDict (−1.9 Ir, −0.22%). The
`dict` control moved by abo... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line