aio-libs / multidict / 37428937038

86%

push

github

Remove unused bitmap_reserve(), reflist_size() and slot_identity() (#1689)

<!-- Thank you for your contribution! -->

## What do these changes do?

Removes `bitmap_reserve()` (`bitmap.h`), `reflist_size()` (`reflist.h`)
and `slot_identity()` (`htkeys.h`). Nothing calls them; they only kept
building because `static inline` silences `-Wunused-function`. The
helpers they called, `_bitmap_start()` and `_reflist_spilled_size()`,
still have other callers. A comment that pointed at `slot_identity()`
now points at `compact_key_identity()`.

Pure Python has no equivalent; this only touches the C extension's
headers.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, dead code removal)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

The disassembly of `_multidict` is byte-identical to master on 3.10.17,
3.14.7 and 3.14.7t (GCC 15). Builds with clang and with
`MULTIDICT_DEBUG_BUILD=1`.

Tests: `pytest -q` on 3.14.7 (4089 passed) and 3.14.7t (4074 passed).
`tools/check_inlining.py`, pre-commit and `make doc-spelling` pass.
</details>

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line