decentraland / comms-gatekeeper / 37379383673

89%

push

github

feat: keep serving and keep data for opted-out world scenes (#302)

* feat: keep serving and keep data for opted-out world scenes

A world whose owner opts out of Places has its scenes stored disabled
with disabled_reason = 'opt_out', though they are still deployed.

- Place lookups by parcel / world scene ask Places to include opted-out
  scenes, so admins, bans and cast work for them.
- The weekly places checker and the disabled-places bans removal skip
  opted-out places instead of wiping their admins, stream access and
  bans. Without disabled_reason (older Places) behaviour is unchanged.

Requires decentraland/places#893.

* fix: only ask places for opted-out scenes on world lookups

Places honours include_opted_out only together with names, and opt
out only exists for worlds, so the flag did nothing on the Genesis City
parcel lookup. Drop it there and cover isPlaceRemoved directly,
including a disabled place without a reason (older Places).

1415 of 1734 branches covered (81.6%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 3 files covered. (100.0%)

3694 of 4088 relevant lines covered (90.36%)

94.63 hits per line