decentraland / comms-gatekeeper / 36460712875

89%

push

github

fix: recover missing island assignments from Pulse (#300)

* fix: recover island assignments from Pulse authority

* fix: bound recovery work and reject stale assignments

* fix: address the review on authority-based island recovery

- Stop closing the NATS connection on a slow flush. A publish ends
  confirmed, unconfirmed or dropped; an unconfirmed one is counted and
  still recorded, and a dead link is left to the client's own pings.
- Tell "no Pulse instance owns this session" from "Pulse unreachable":
  requests carry a status, with separate counters and a latency
  histogram by outcome.
- Add CLUSTER_AUTHORITY_LOOKUP_ENABLED as the rollback switch for a
  Pulse without the assignment endpoint, and mint change edges when the
  LiveKit membership check fails; connects and hints keep failing
  closed, with the crash-reconnect bound documented.
- Keep evicting the displaced session of a superseded takeover edge
  unless it is active again or this replica has since handed its room
  to a newer session.
- Require a session key on every connect and change event, counting
  malformed ones; the connect event has carried one since it existed.
- Bound concurrent connect resolutions with CLUSTER_CONNECT_CONCURRENCY.
- Accept a bare HTTP 404 in holdsParticipant, share positiveIntegerOr
  from the config utils and reject non-finite numbers, health-check the
  CI broker and fail the job when the broker suite did not run.

* fix: leave a superseded takeover's participant alone without a mint on record

A wrong eviction removes the live device's participant and revokes its
token, and the client treats that as a takeover of its own device: it
stops reconnecting and shows the exit modal. So the superseded-edge
eviction now runs only when this replica knows what it last minted for
the wallet; with no record, after a restart or an hour idle, the
displaced session is left in place and counted as skipped.

Peer state is no longer read by fromIslandId alone, so its com... (continued)

1412 of 1731 branches covered (81.57%)

Branch coverage included in aggregate %.

130 of 131 new or added lines in 4 files covered. (99.24%)

3690 of 4084 relevant lines covered (90.35%)

94.54 hits per line