kobotoolbox / kpi / 37357713478

83%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(trashBin): stop suspending owner submissions during project deletion DEV-3009 (#7666)

### 📣 Summary

Permanently deleting a project no longer pauses data collection on the
owner's other projects.

### 📖 Description

While a project was being permanently deleted, every other project of
the same owner refused new submissions until the deletion finished. If
the deletion kept failing, the owner couldn't collect data on any
project at all. Now the owner's other projects keep accepting
submissions while a project is being deleted.

### 💭 Notes

- Partial revert of DEV-2513 (#7553): `delete_asset()` no longer wraps
the deletion in `suspend_submissions(owner)`. `submissions_suspended` is
only meant for counter sync, so the storage recount keeps using it
(holders, lease and `release_orphaned_suspensions()` are unchanged, only
their comments are).
- The trashed project itself still refuses submissions: trashing sets
`XForm.downloadable=False`, so `check_active()` raises
`FormInactiveError`.
- Why it matters: when a deletion worker is killed without a traceback
(e.g. OOM), `finally` never runs and the flag stays on. `task_restarter`
then re-runs the deletion every 30 min and suspends the owner again.
- Tradeoff: the deadlock DEV-2513 was after can come back, but DEV-2511
already makes it retryable. A deletion and a submission to another
project only share the `UserProfile` row, so the likelier cause is two
deletions of the same owner racing on the catch-all counters
(`update_catch_all_counter_on_delete` loops without `order_by`). That's
a follow-up.
- This doesn't unlock accounts that are already suspended. They have no
live holder anymore, so `fix_stale_submissions_suspended_flag` will
release them.

### 👀 Preview steps

1. ℹ️ have an account with two deployed projects, A and B
2. move A to the trash and empty it
3. while the deletion runs (e.g. with a breakpoint in
`_delete_submissions()`), submit to B
4. 🔴 [on main] B answers 503 "Temporarily unavailable... (continued)

Coverage Stats

10303 of 13642 branches covered (75.52%)

0 of 2 new or added lines in 1 file covered. (0.0%)

2837 existing lines in 127 files now uncovered.

32958 of 39718 relevant lines covered (82.98%)

5.5 hits per line