kobotoolbox / kpi / 36744966686

83%

master: 76%

push

github

fix(uploads): handle external_choices correctly DEV-2857 (#7635)

### 📣 Summary
Allow users to import files with untranslated `external_choices` iff no
other columns are translated.

### 💭 Notes
Most of the work is done with the formpack upgrade
https://github.com/kobotoolbox/formpack/pull/353. The additional line in
this PR prevents users from uploading forms where the regular columns
are translated but the external_choices are not.


### 👀 Preview steps

1. ℹ️ have an account and a project
2. Upload
[select_one_external_missing_external_translations.xlsx](https://github.com/user-attachments/files/32857124/select_one_external_missing_external_translations.xlsx)
4. 🔴 [on main] upload succeeds but deploy fails
5. 🟢 [on PR] upload fails because the Label column is not translated
6. Add translations to the external_choices sheet and reupload
7. 🟢 [on PR] upload succeeds

10305 of 13645 branches covered (75.52%)

1 of 1 new or added line in 1 file covered. (100.0%)

32959 of 39722 relevant lines covered (82.97%)

5.51 hits per line