urwid / urwid / 37321592932

90%

push

github

Leave zero-width controls out of text canvases (#1398)

Text and Edit measure a control character or escape sequence as zero
columns, but the displays drew it: the raw display drew "?" for each
C0/C1 character and sent DEL intact. Untrusted text overflowed its
column and overwrote the next widget, and a narrow encoding raised
CanvasError.

- apply_text_layout leaves out of each layout segment what the measure
  that sized it takes as zero columns: escape sequences and control
  characters where calc_width sized it, only the control characters
  where calc_text_pos cut it inside a sequence. Each line is drawn in
  the columns the layout measured.
- The layout, get_text(), edit_text and text offsets are unchanged, so
  code measuring the original text with calc_width matches the screen.
- TAB, LF, SO and SI are kept, and so are bytes in a narrow encoding,
  measured as the one "?" column the display draws for each.
- The raw display test builds its canvas directly, as Text no longer
  passes control characters to it.

4696 of 5628 branches covered (83.44%)

Branch coverage included in aggregate %.

43 of 43 new or added lines in 1 file covered. (100.0%)

11722 of 13354 relevant lines covered (87.78%)

9.81 hits per line