urwid / urwid / 37330061543

90%

push

github

Deprecate non-integer index in deque insert() (#1399)

MonitoredDeque.insert() and MonitoredFocusDeque.insert() converted the
index with int(), so a float, a Decimal or a numeric string was accepted
where collections.deque.insert() raises TypeError.

- Convert the index with operator.index(), matching deque.insert().
- Keep converting any other value int() accepts, with a
  DeprecationWarning announcing TypeError from version 5.0.
- Pass the converted index on from MonitoredFocusDeque.insert(), so the
  warning is emitted once.
- Record the deprecation in the changelog.

Also fix failures found running the suite on PyPy, GraalPy and 3.13t:

- Check Columns, Pile and scale_bar_values() sizes through float():
  GraalPy's math.isfinite() accepts an int too large for a float.
- Make the gpm pipe non-blocking with os.set_blocking(): GraalPy's
  fcntl module has no fcntl().
- TrioEventLoop runs idle callbacks only while its nursery is open, lets
  them change the idle callbacks, and raises their exceptions from run(),
  where Trio logged them and dropped the idle emulation; changelog entry.
- Tests poll for the awaited output instead of relying on alarm delays,
  collect garbage until stable in leak tests, and skip tests that need
  reference counting or mortal classes where those do not hold.

4696 of 5628 branches covered (83.44%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 4 files covered. (100.0%)

11736 of 13367 relevant lines covered (87.8%)

9.81 hits per line