urwid / urwid / 37302252281

90%

Build Type

push

github

Committed by web-flow

Commit Message

Handle contents changed by widget callbacks (#1397)

A callback run while a container dispatches input, or while a focus
list mutates, could change the contents under the caller, which then
continued from stale indexes. No public signature changes.

- GridFlow: skip syncing the focus from the display widget after a
  key or mouse handler changed the contents.
- MonitoredFocusList/Deque: set the focus before the single modified
  notification, so its callback sees the final focus and a focus it
  sets is kept; the focus-changed callback now runs first.
- MonitoredFocusDeque: += adjusts the focus like extend.
- MonitoredList: + and n * list return a new list and leave this one
  unchanged, so they no longer send a modified notification.
- Pile/Columns: re-read the focus and sizes after the child returns
  an unhandled key; move_cursor_to_coords returns False when the
  child changed the contents; Pile keeps placing the cursor in the
  newly focused child.
- RadioButton.set_state: stop clearing the group once a handler
  moved the selection off this button.

Coverage Stats

4679 of 5612 branches covered (83.37%)

Branch coverage included in aggregate %.

64 of 64 new or added lines in 6 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

11684 of 13316 relevant lines covered (87.74%)

9.81 hits per line