zostera / django-bootstrap4 / 37196601546

100%

push

github

Cover pagination with tests (#905)

First of three passes toward 100%, mirroring the series done in
django-bootstrap3 (#1157, #1158, #1159).

get_pagination_context had no tests at all: 62 statements behind the public
bootstrap_pagination tag. The tag itself and bootstrap_url_replace_param were
untested too.

24 tests cover the page window and both clamps, the URL handling, the size and
justify-content modifiers, and the two template tags end to end.

The URL behaviour differs from django-bootstrap3 and the tests say so. This
package parses and rebuilds the URL with urlparse and urlencode rather than
stripping the page parameter with regular expressions, so an existing
page=N survives into the base URL. That is harmless: pagination.html builds
every link with bootstrap_url_replace_param, which overwrites the parameter.
I checked the template before concluding it was not a bug.

The guard at `if half_page_num < 0` is removed, as in django-bootstrap3.
pages_to_show is coerced with int() and anything below 1 raises on the line
above, so floor(n / 2) cannot be negative.

The file goes from 81% to 93%, the package from 87% to 90%.

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

245 of 286 branches covered (85.66%)

Branch coverage included in aggregate %.

742 of 810 relevant lines covered (91.6%)

14.66 hits per line