coreui / coreui-pro / 37146753865

96%

main: 94%

push

github

fix(DateInput): leave keys with Alt, Ctrl or Meta to the browser (#1539)

* fix(DateInput): leave keys with Alt, Ctrl or Meta to the browser

A section took the arrow keys, Home and End whatever modifier was held,
moving focus or the value and cancelling the key. It typed a digit
pressed with Ctrl, Meta or Alt, and a read-only field cancelled every
one-character key, Ctrl+C included. At the separator, DateRangeInput
moved focus across on a modified arrow as well.

Two util helpers now decide it. hasShortcutModifier() tells a press with
Alt, Ctrl or Meta, on which a section and the range separator move no
focus, change no value and cancel nothing, so the browser, assistive
technology and a picker around the field get the key; Alt+ArrowDown
reaches the date picker this way. isTypedKey() types one character with
no modifier. A character that AltGr or Option composes is not typed on
keydown and reaches the section through the beforeinput path instead.
In a section, which is contenteditable, the browser's own default for a
modified arrow is a caret move inside it.

* chore: raise the coreui.js, coreui.bundle.js and coreui.esm.js budgets

The modifier key helpers add 230 B to coreui.js and coreui.bundle.js and
234 B to coreui.esm.js (gzip -9, against v6-dev), nearly all of it their
JSDoc; the minified files move by 6 B at most. That takes coreui.js over
its ceiling and leaves the other two with a few dozen bytes, so each
goes up by 0.25 kB.

6781 of 7334 branches covered (92.46%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 3 files covered. (100.0%)

11937 of 12230 relevant lines covered (97.6%)

1488.28 hits per line