coreui / coreui-pro / 37118145825

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(MultiSelect): point the toggler's aria-controls at the dialog (#1527)

The MultiSelect toggler is a combobox with `aria-haspopup="dialog"` and the panel is the `role=dialog`, but the toggler's `aria-controls` named the listbox inside the panel. It now names the panel, which gets an id for it, the way the pickers point at theirs; the search input keeps pointing at the listbox it filters.

ComboboxBase now takes the panel references as element and target pairs, so one component can point two elements at different parts of the panel. React and Vue get the same change in coreui-react-pro and coreui-vue-pro on the same branch name.

The coreui.js budget goes up by 0.25 kB: this change adds 32 to 51 B gzip per bundle and brings coreui.js to its ceiling.

Coverage Stats

6752 of 7304 branches covered (92.44%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

11911 of 12204 relevant lines covered (97.6%)

1482.85 hits per line