wboayue / rust-ibapi / 37097506242

98%

Build Type

push

github

Committed by web-flow

Commit Message

transport: partition request and order ids, route by range (#789) (#912)

Request ids (from 9000) and order ids (from nextValidId) shared one i32
space; an error frame carries one id, so a collision sent an order's 202/201
to a data subscription, or a late request error onto the order-update stream.

- REQUEST_ID_FLOOR = 1_500_000_000: request ids at/above, order ids below;
  allocator stops at i32::MAX - 1
- typed RequestId / OrderId / WireId (crate-private); WireId::classify
  routes frames and errors by range; drop request-then-order fallback and
  id_owned_by_data_request
- place_order/submit_order/cancel_order/exercise_options/next_valid_order_id
  reject order ids at/above the floor (incl. parent_id and preset attached
  ids); seed at/above floor -> ConnectionRejected
- bus traits, routing tables, cleanup signals, request builders typed
- tests migrated to RequestId::nth; #789 regression tests on both clients;
  live floor-echo test in integration/sync
- changelog, migration-5.0 note, docs/rules/wire/id-partition.md
- entry-point rejection tests (sync + async); connect rejects seed at floor
- reconnect logs a next valid id in the request range

Coverage Stats

302 of 313 new or added lines in 24 files covered. (96.49%)

1 existing line in 1 file now uncovered.

19832 of 20959 relevant lines covered (94.62%)

75.94 hits per line