wboayue / rust-ibapi / 37082738616

98%

Build Type

push

github

Committed by web-flow

Commit Message

transport: cancel unregisters by identity, not by key (#894) (#910)

Bus cancel_subscription/cancel_order_subscription sent Cancelled to, then
removed, whatever was registered under the id, poisoning a successor.

- remove both methods from MessageBus and AsyncMessageBus
- sync: InternalSubscription::cancel sends the same sender-tagged cleanup
  signal as drop; cleanup removes via remove_if_same
- callers write the cancel with send_message
- async historical ticks end locally on cancel (Err(Cancelled), then None);
  registration released at drop by liveness
- drop now-unused SenderHash::remove

Coverage Stats

20 of 21 new or added lines in 4 files covered. (95.24%)

5 existing lines in 2 files now uncovered.

19727 of 20849 relevant lines covered (94.62%)

75.29 hits per line