bleedingdeacons / link / 37088214912
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 30
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.633% (+1.8%) from 89.808%
37088214912

push

github

web-flow 
fix(sync): poll from where the last poll got to, and walk every page (#72)

* test: prove a later push and a long absence both lose messages

Message 9's push drops, message 10's arrives, and the next sync asks for
everything above 10: 9 is never fetched. Deleting 10 does the same through
the cleared-up-to mark. And a handset more than a page behind collects the
newest page and never the rest.

The spec double now pages as Fellowship does today, fifty at a time,
newest first; a double that answered everything at once could never show
the second of those.

* fix: poll from where the last poll got to, and walk every page

A push used to raise where the next poll started, because the poll asked
from the highest id held. Message 9's push dropped, message 10's arrived,
and the next sync asked for everything above 10: 9 was never fetched.
Deleting a pushed message did the same through the clear mark.

The history now keeps a poll mark of its own. Only a sync moves it, and
only as far as the highest id it opened, so a handset whose key has gone
stays put and a replaced key still brings everything back. A pushed
message is therefore collected once more by the poll; it is not counted
as received twice, and its copy carries the read flag a push never has.

A sync now walks forward a page at a time while Fellowship says there is
more, up to ten pages, so a handset that has been away catches up in one
pass. Against a Fellowship too old to say, it collects a page per sync.

Files written before this carry no poll mark, so the first sync after
upgrading asks from the clear mark or the beginning, and collects
whatever a later push once hid.

1566 of 1709 relevant lines covered (91.63%)

21.78 hits per line

Coverage Regressions

Lines Coverage ∆ File
20
92.69
8.54% Services/JsonMessageHistory.cs
15
91.85
0.65% Services/MessageService.cs
11
95.33
0.01% Services/FellowshipClient.cs
8
81.16
0.28% Services/Interfaces/IFellowshipClient.cs
Jobs
ID Job ID Ran Files Coverage
1 37088214912.1 30
91.63
GitHub Action Run
Source Files on build 37088214912