coreui / coreui-pro / 36997811375

96%

main: 94%

push

github

fix(pickers): keyboard and screen reader fixes in the picker shell (#1516)

* fix(DatePicker, DateRangePicker, TimePicker): keep a disabled picker closed from the keyboard

F4 and Alt+ArrowDown on the field go to Popup.show(), which skipped the
disabled check PickerBase.show() makes, so a disabled picker opened its panel
and the toggle reported aria-expanded="true" (measured in Chromium on all
three pickers after a click put focus in a section). The check moves into the
popup's onBeforeShow, which every way of opening goes through.

* fix(DatePicker, DateRangePicker, TimePicker): hand focus to the field when the cleaner clears it

The cleaner hides once the value is gone, and when it held the focus nothing
took it over, so a keyboard user who cleared a picker landed on the body
(measured in Chromium on all three pickers). Clearing from the cleaner now
moves focus to the first section of the field, the start field of a range.

* fix(DatePicker, DateRangePicker, TimePicker): keep the visible text of an adopted button in its name

An adopted toggle or cleaner without a name of its own got ariaPickerLabel or
ariaCleanerLabel as aria-label even when it showed text, so the docs example's
"Pick a date" button was announced as "Toggle calendar", a name that does not
contain its visible label. The label is now written only on a button with no
text of its own, an icon-only one.

* feat(DatePicker, DateRangePicker, TimePicker): name the panel with ariaPopupLabel

The panel opens as a role="dialog" with no accessible name, so a screen
reader announced an unnamed dialog. The new ariaPopupLabel option names it,
"Calendar" on the date and date range pickers and "Time selection" on the
time picker by default (measured in the Chromium accessibility tree).

* fix(DatePicker, DateRangePicker, TimePicker): name icon buttons whose icon carries text, and other review fixes

The label-in-name check read textContent, which counts an svg <title> or
<style> and aria-hidden tex... (continued)

6705 of 7254 branches covered (92.43%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 2 files covered. (100.0%)

11835 of 12129 relevant lines covered (97.58%)

1457.7 hits per line