coreui / coreui-pro / 36933595992

96%

main: 94%

push

github

fix(Calendar): treat a week as a period, like a month (#1514)

* fix(Calendar): treat a week as a period, like a month

Week selection judged a week by one day of its row, so each rule had to
pick its own day: the row's first day for disabledDates, a limit moved
to a row date for the limits, and with Tuesday to Thursday first the
calendar and the date field checked disabledDates on different days and
disagreed on whether a week could be picked.

An ISO week is now a period next to months, quarters and years:
getPeriod, isPeriodDisabled, isPeriodSelected, isPeriodInRange and
isCellDisabled take 'weeks', and a row is judged by the week of its
middle day. A pick gives the Monday of that week, the date 2026W36
stands for. minDate and maxDate are rounded out to whole weeks
(convertToLimitDate), so the week of a limit stays selectable and focus
and keyboard edges need no week rules of their own, and disabledDates
disables a week only when it disables every day of it, as it does for a
month. The week field of the date picker rounds its limits and checks a
week the same way, so both agree on any first day of the week.
getWeekDate, isWeekSelected and isWeekInRange are gone.

* fix(Calendar): give a week limit the Thursday of its week

Rounding minDate and maxDate out to the Monday and Sunday of their ISO
week ignored firstDayOfWeek, so with any other first day a limit reached
into the neighbouring row: that row took the focus although it stood for
a week outside the limits, the default tab stop and Page Up / Page Down
stopped on it, and the months view opened a month whose page held no
week to pick. A week limit is now the Thursday of its week, which the
row that stands for that week always holds, so focus, the keyboard, the
default page and the months view find that row by its days.

disabledDates still disables a week only when it disables every day of
it, now over all seven days, since the limits count as whole weeks; the
date field reads its limits as befo... (continued)

6695 of 7243 branches covered (92.43%)

Branch coverage included in aggregate %.

56 of 56 new or added lines in 3 files covered. (100.0%)

11831 of 12125 relevant lines covered (97.58%)

1453.86 hits per line