romshark / datapages / 36925427994

53%

Build Type

push

github

Committed by romshark

Commit Message

fix: Supply every PageError404 input in render404

render404 read only the session, while the GET call it writes passes
every input the handler declares. A PageError404.GET taking a path, a
query, signals or a dispatcher generated

    body, err := p.GET(r, path, query, signals, dispatchMissed)

with none of them declared, which doesn't compile: "undefined: path".

render404 serves PageIndex's fallback for paths no route matches, never
the 404 page's own route. It reads that URL's query and signals and
leaves the path zero.

Coverage Stats

36 of 36 new or added lines in 2 files covered. (100.0%)

22 existing lines in 1 file now uncovered.

14563 of 36080 relevant lines covered (40.36%)

545.81 hits per line