romshark / datapages / 36923843324

53%

Build Type

push

github

Committed by romshark

Commit Message

fix: Reject ambiguous handlers in embedded types

flattenPage keeps the first action of a name and visits each abstract
page once. A page that embeds two types defining POSTSave, or reaches
one abstract page through two embedded fields at one depth, passed
lint and gen, and the generated call did not compile:
"ambiguous selector p.POSTSave".

The check uses types.LookupFieldOrMethod, which applies Go's
selector rules: a shallower method still shadows a deeper one.
A handler declared on the page resolves the ambiguity.

Coverage Stats

41 of 46 new or added lines in 1 file covered. (89.13%)

2 existing lines in 1 file now uncovered.

14551 of 36056 relevant lines covered (40.36%)

546.04 hits per line