uber / h3-go / 36899345789

100%

push

github

conformance: add the suite format, an inspection group and its C generator (#146)

Start the language-neutral H3 conformance suite under x/h3go/conformance. It
extends the newline-delimited JSON test files begun in uber/h3#1230: records
are keyed by subject and keep that PR's key names, so its runner can still read
them, and the format adds what a port needs to vendor the files on their own.

- README.md is the specification: layout, manifest, value conventions (index
  strings, errors as H3Error enum names, sets versus sequences), the
  floating-point tolerance model (angular distance on the sphere for
  coordinates, relative error for measures), the inspection group, and the
  full sampling procedure including the splitmix64 source, so a generator in
  another language reproduces the files byte for byte from the same seed.
- format.go holds the manifest and record types, a Result type that encodes
  as either a value or {"err": "E_..."}, the NDJSON reader and writer, and
  manifest loading that rejects a file whose hash or line count has changed.
- internal/gen/gen.c is a standalone C99 program against the public H3 API,
  compiled by generate.sh against the vendored sources, so every expected
  value is the C library's own answer and the file can move to uber/h3 as a
  testapp unchanged. go generate rebuilds and runs it. It reproduces the
  output of the Go generator the suite was first drafted with byte for byte.
- testdata/inspection/cells.jsonl holds 1,885 records: every base cell, every
  pentagon at every resolution, seeded random cells, six field mutations of
  seeded cells, directed edges and vertexes, and raw 64-bit patterns. Each
  records getResolution, getBaseCellNumber, isValidCell, isValidIndex,
  isResClassIII, isPentagon, getIcosahedronFaces, all fifteen getIndexDigit
  values and constructCell. x/h3go passes all of them.

Compared with #1230's file: faceError:-1 becomes faces:{"err":...} (the
upstream runner's faceError branch never... (continued)

99 of 99 new or added lines in 1 file covered. (100.0%)

4516 of 4516 relevant lines covered (100.0%)

2669389.9 hits per line