panates / rman / 36832014276

95%

push

github

fix(progress): one region draws at a time, so the bottom lines stop swapping

Every command gets a status region, and run/build/exec/clean/ci/changelog
additionally start a progress panel - so two live regions redrew on one
terminal. Each moves the cursor up by its own line count, so interleaved every
redraw lands on the other's rows, and on screen the last line and the status
line swap places several times a second. Reported on `rman ci`; `rman build`
had it too by a second route, since `runBin`'s pass-through went to the status
region while the panel was drawing.

`LiveRegion`'s own doc has claimed "only one region is ever live" since it grew
a `stream` parameter. Nothing held it to that. `ProgressPanel.start(statusRegion)`
now takes the terminal and `stop()` hands it back, and all five panel sites pass
`app.statusRegion`.

`live` stays true while suspended, deliberately: it answers "does something own
this terminal", which is what `runBin` reads to decide to pipe a child rather
than let it scroll the screen. Which region is drawing is `takeover`, which
`passThrough` forwards to. Making `live` false would have let every runBin child
inherit the terminal and scroll over the panel.

Measured on panates/sqb with a 3s `rman exec`: before, the `exec sqb` spinner
interleaved with every panel frame; after, only the panel draws and the result
line still prints when it comes down.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

3099 of 3388 branches covered (91.47%)

Branch coverage included in aggregate %.

87 of 95 new or added lines in 7 files covered. (91.58%)

18703 of 19690 relevant lines covered (94.99%)

208.24 hits per line