valkyrjaio / valkyrja-php / 36808334073

100%

push

github

[Auth] feat!: Move the session authenticator settings into their own config contract (#1332)

# Description

Move the settings that only `SessionAuthenticator` reads out of
`AuthConfigContract` and into a new `AuthSessionConfigContract`, because
a component config must not hold the config of an adapter.
`AuthSessionConfig` implements the new contract, and its properties take
the `session` prefix, so one application config class can implement it
next to the other auth contracts.

This breaks an application that sets `AuthConfigContract::$session`.
Implement `AuthSessionConfigContract` on the application config, and set
`sessionItemId` and `sessionAllowedClasses` instead.

The stores and the password hasher have no settings, so they get no
contract.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [x] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`AuthSessionConfigContract`** — the session authenticator contract.
- **`AuthSessionConfig`** — implements the contract, with the `session`
prefix on each property.
- **`AuthConfigContract`, `AuthConfig`** — no longer hold the session
authenticator config.
- **`AuthServiceProvider`** — publishes the session authenticator config
as its own binding, and builds `SessionAuthenticator` from it.
- **`README.md`** — documents the new contract and its binding.
- **Tests** — cover the new contract and binding, and prove that
`SessionAuthenticator` takes its session item id from the new binding.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

22 of 22 new or added lines in 1 file covered. (100.0%)

13004 of 13004 relevant lines covered (100.0%)

26.2 hits per line