valkyrjaio / valkyrja-php / 36808208012

100%

push

github

[CliServer] feat: Publish the server config contracts with default implementations (#1334)

# Description

Give each of the five CLI server config contracts a default
implementation, and publish each contract as its own container binding.
The contracts had no default implementation, so
`CliServerServiceProvider` tested the application config with
`instanceof` inside each middleware publisher and fell back to
constants. Every other component publishes each config contract as a
binding and reads that binding, and the component config rules require
the default implementation.

The defaults hold the same names as the constants they replace, so the
built-in command and option names do not change.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [x] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`CliHelpCommandConfig`, `CliVersionCommandConfig`,
`CliNoInteractionConfig`, `CliQuietInteractionConfig`,
`CliSilentInteractionConfig`** — the default implementation of each
contract.
- **`CliServerServiceProvider`** — publishes each contract as its own
binding, and the help, version and interaction option middleware read
those bindings.
- **`README.md`** — states that the provider binds the application
config or the default implementation.
- **`CommandParameterPresenceTest`** — registers the five config
publishers in the container data it builds, the way a component provider
does.
- **Tests** — cover each default implementation and both branches of
each config publisher.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

62 of 62 new or added lines in 6 files covered. (100.0%)

12993 of 12993 relevant lines covered (100.0%)

26.21 hits per line