valkyrjaio / valkyrja-php / 36808031888
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1201
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
36808031888

push

github

web-flow 
[CliRouting] deprecate!: Remove the unused cli routing config contract (#1335)

# Description

Remove `CliRoutingConfigContract`. Nothing reads its `dataClassName`
property. The CLI routing component never loads a cached data class by
name: `CliRoutingServiceProvider::publishData` builds `CliRoutingData`
from the application's CLI providers at run time, and the generated data
classes reach the container through the application config's provider
list. HTTP routing has no equivalent contract, so the contract also had
no sibling.

The contract arrived with the change that converted the config to
explicit interfaces, and no consumer followed it. The three configs in
`CliTest` that set `dataClassName` had no effect, so they lose the
property and the interface.

This breaks an application config that implements the contract. Drop the
interface and the property from that config; the framework reads
neither.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [x] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`CliRoutingConfigContract`** — removed.
- **`CliRoutingConfigFixture`** — removed, because the contract it
implemented is gone.
- **`CliTest`** — the three application configs no longer implement the
contract or declare `dataClassName`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

12962 of 12962 relevant lines covered (100.0%)

26.19 hits per line

Jobs
ID Job ID Ran Files Coverage
1 36808031888.1 1201
100.0
GitHub Action Run
Source Files on build 36808031888