valkyrjaio / valkyrja-php / 36808021140

100%

push

github

[Session] feat!: Name the php session config for its adapter (#1336)

# Description

Name the config of the `PhpSession` adapter for that adapter.
`SessionCookieConfigContract` is read by `PhpSession` alone, which hands
the values to `session_set_cookie_params()`. The name said `Cookie`, so
it read as the config of `CookieSession`, and `CookieSession` does not
read it. The contract is now `SessionPhpConfigContract`, the default
implementation is `SessionPhpConfig`, and each property carries the
`php` adapter prefix.

This breaks an application config that implements the contract.
Implement `SessionPhpConfigContract` instead, and rename each property
to its prefixed spelling, such as `cookiePath` to `phpCookiePath`.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`SessionPhpConfigContract`, `SessionPhpConfig`** — renamed from the
cookie spelling, with the `php` prefix on every property.
- **`PhpSession`** — reads the renamed properties.
- **`SessionServiceProvider`** — publishes the renamed contract.
- **`README.md`** — documents the renamed contract and properties.
- **Tests** — follow the rename.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

14 of 14 new or added lines in 3 files covered. (100.0%)

12962 of 12962 relevant lines covered (100.0%)

26.19 hits per line