valkyrjaio / valkyrja-php / 36807876113

100%

push

github

[Jwt] feat!: Move the signing algorithm onto the firebase adapter config (#1337)

# Description

Move the signing algorithm out of the component config and onto a
contract for the adapter that reads it. `FirebaseJwt` is the only reader
of `algorithm`, and the component config is for settings that apply to
the whole component. `JwtFirebaseConfigContract` now carries
`firebaseAlgorithm`, the service provider publishes it as its own
binding, and `publishFirebaseJwt` reads the algorithm from that binding.

The key contracts stay as they are. A key belongs to an algorithm family
rather than to one adapter, so any JWT adapter can read them.

This breaks an application config that implements `JwtConfigContract`
and sets `algorithm`. Implement `JwtFirebaseConfigContract` as well, and
rename the property to `firebaseAlgorithm`.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [x] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`JwtFirebaseConfigContract`, `JwtFirebaseConfig`** — the adapter
contract that carries the algorithm, and its default implementation.
- **`JwtConfigContract`, `JwtConfig`** — no longer hold the algorithm.
- **`JwtServiceProvider`** — publishes the new contract as its own
binding, and builds `FirebaseJwt` from it.
- **`README.md`** — documents the new contract and its binding.
- **Tests** — cover the new config and both branches of its publisher,
and the algorithm cases now configure the adapter contract.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

21 of 21 new or added lines in 2 files covered. (100.0%)

12962 of 12962 relevant lines covered (100.0%)

26.18 hits per line