coreui / coreui-pro / 36747125001

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(Rating): keep a read-only rating in the form (#1488)

* fix(Rating): keep a read-only rating in the form

readonly disabled the radios, so the form left a read-only rating out of
its data, unlike a native read-only field, which is submitted.

The radios now stay enabled for readonly (only disabled disables them),
and a click on a read-only star is cancelled. Measured in Chromium and
Firefox, an arrow key that moves through a radio group also fires a
cancellable click, so the same handler keeps the value for the keyboard,
while focus still moves between the stars. The group carries
aria-readonly="true" while readonly is on; dispose() gives the element the
aria-readonly it had.

* chore: raise the coreui.js, coreui.esm.min.js and coreui.bundle.min.js budgets

The read-only rating change adds 69 B to coreui.js, 69 B to
coreui.esm.min.js and 70 B to coreui.bundle.min.js (gzip-size, the measure
bundlewatch applies; 6bc66e3d1 against e24a0bd8d). That leaves them 16 B,
2 B and 19 B under their ceilings, so each goes up by 0.25 KB before the
next change runs into them.

* fix(Rating): submit a read-only rating only under a given name

A read-only rating without `name` sent its value under the generated key,
so a rating that only shows a score added a random field to the form. It
now uses only the name the page gives it.

Only the checked star of a read-only rating takes focus and the arrow keys
are cancelled, so focus stays on the value (checked in Chromium, Firefox
and WebKit). A star with keyboard focus shows the focus ring. Focusing a
read-only star no longer fires `hover.coreui.rating` or builds a tooltip,
and an `aria-readonly` the markup already has is left alone.

* chore: raise the coreui.bundle.js, coreui.esm.js and coreui.min.js budgets

The read-only Rating work adds 128 B to coreui.bundle.js, 147 B to
coreui.esm.js and 113 B to coreui.min.js (gzip, against 6bc66e3d1), which
left 35, 49 and 71 bytes under the ceilings. Each goes up by 0.25 kB.

Coverage Stats

6410 of 6964 branches covered (92.04%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

11526 of 11834 relevant lines covered (97.4%)

892.42 hits per line