hyperledger-labs / fabric-smart-client / 36725991796

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): fail state views on a bad reply and a short recipient exchange (#1982)

The receive views in platform/fabric/services/state dereferenced the
received message without checking that the session channel was open,
so a closed session panicked the view instead of failing it.

receiveView, payloadReceiveView, sendReceiveView,
receiveTransactionView and RequestRecipientIdentityView now read their
reply through session.ReadMessageWithTimeout instead of each running
its own timer and select. They all fail the same way on a nil or
closed receive channel, a nil message, an ERROR reply or a timeout,
and a bad reply binds nothing:
- a nil receive channel fails at once instead of blocking until the
  timeout;
- an ERROR reply returns "received error from remote [<payload>]"
  instead of the raw payload, and a timeout returns "time out
  reached";
- the per-view timeouts are unchanged.

ExchangeRecipientIdentities and RespondExchangeRecipientIdentities
return an error when the view result does not hold exactly two
identities.

Fixes #1964

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

33 of 34 new or added lines in 3 files covered. (97.06%)

20 existing lines in 8 files now uncovered.

29001 of 32058 relevant lines covered (90.46%)

2255.49 hits per line