hyperledger-labs / fabric-smart-client / 36710996062

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(config, web)!: bound request bodies, report websocket read errors, simplify decode hooks (#1970)

web/server:
- limit HTTP request bodies to maxMessageSize (10 MiB, the websocket
  message limit) with http.MaxBytesReader and answer 413 "request too
  large" when exceeded
- answer 500 "invalid status code from backend" when a RequestHandler
  returns a status code outside 100-999, which made WriteHeader panic
- WSStream.Read returns the ReadMessage error instead of nil, so Recv and
  ReadInput report a closed connection rather than a JSON decode error
- replace negotiateContentType with acceptsJSON, which parses each Accept
  entry with mime.ParseMediaType; values such as "application/jsonx" are
  rejected, parameters such as "; charset=utf-8" or "q=0.8" are accepted
- remove the unused Config type

config:
- compile the byte size regexp once and read both groups with a single
  FindStringSubmatch
- customDecodeHook decodes "[]" to an empty slice instead of [""]
- drop the unreachable reflect.String branches from the file hooks and
  flatten them
- pemBlocksFromFileDecodeHook reports an empty File value as empty, not nil
- fix the customDecodeHook and initConfigPaths comments

pkg/utils/errors:
- HasType returned true for every non-nil error, because errors.As with a
  *error target matches any error; it now delegates to the type check of
  cockroachdb/errors

BREAKING CHANGE: server.Config is removed; it had no users.

Fixes #1967

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

93 of 95 new or added lines in 4 files covered. (97.89%)

4 existing lines in 3 files now uncovered.

28849 of 32113 relevant lines covered (89.84%)

2339.5 hits per line