hyperledger-labs / fabric-smart-client / 36700470709

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabricx): keep vault reads, appends and equality consistent (#1960)

The FabricX vault keeps no local state, so a defect in how it records
reads or pins namespace versions reaches the committer as a stale or
malformed transaction rather than as a local error.

GetState replaced the recorded read version when a key was read again
after a commit had changed it. The caller had already acted on the
earlier value, yet IsValid then accepted the simulation. A re-read at a
different version now returns an error and the original read version is
kept.

Append stopped at the first invalid namespace ID and left the namespaces
before it in the destination RWSet without a pinned version, so the next
Bytes() failed. Append now validates every namespace ID in the payload
before it changes the destination, so a failed AppendRWSet leaves the
RWSet unchanged. A namespace that has only reads is validated as well.

Equals ignored the pinned namespace versions, which are serialized as
NsVersion and covered by the endorsement digest. It now also compares
the version of every namespace with reads or writes.

Marshal rejected a nil namespace version only for namespaces with
writes, and encoded a read-only namespace with a nil version as version
0. Both paths now share one lookup that rejects a missing or nil
version.

Cleanups in the same package:
- Remove the unused rwSetWrapper.qe and queryExecutor.ctx fields and the
  NewQueryExecutor error checks that could never fire.
- Replace versionEqual with bytes.Equal.
- Drop the empty-key-set check in IsValid, which could never be true.
- Pass txIDs straight to GetTransactionStatuses in Statuses.
- Build Namespaces with slices.Collect over a set.

Each fix has a regression test that fails without it. New tests also
cover the paths that had none: IsValid outcomes, namespace pin failures,
GetState/GetDirectState/GetReadAt misses and errors, the GetStateMetadata
field-mapping fallback, Equals, malformed and invalid payloads, vers... (continued)

Coverage Stats

42 of 42 new or added lines in 2 files covered. (100.0%)

16 existing lines in 8 files now uncovered.

28628 of 32115 relevant lines covered (89.14%)

2724.22 hits per line