hyperledger / fabric-x-committer / 36693117376

90%

main: 91%

Build Type

Pull #841

github

Committed by liran-funaro

Commit Message

[grpc, utils] Size the HTTP/2 flow control windows

#### Type of change

- Improvement (improvement to code, performance, etc)
- New feature
- Test update

#### Description

- Adds `connection.FlowControlConfig` (`flow-control`: `initial-window-size`,
  `initial-conn-window-size`) to `ClientConfig`, `MultiClientConfig`, `serve.ServerConfig` and
  `ordererdial.Config`, and applies it to every gRPC dial and server, including orderer delivery
  and broadcast through `deliverorderer.Parameters` and `ordererdial.Parameters`.
- Defaults the windows to 16 MB per stream and 32 MB per connection through `default` tags;
  zero leaves gRPC's own BDP-based tuning in place.
- The load generator picks its adapter by a field each client section needs, not by the
  section being present.
- Documents the keys, commented out with their defaults, in the configuration samples, and the
  knob in `docs/performance-tuning.md`.

#### Additional details (Optional)

- Adds `BenchmarkSignatureVerifierManager` to `signature_verifier_manager_test.go`, which drives
  the verifier manager's sender over a real stream.
- Widens `utils/test` helpers from `*testing.T` to `testing.TB` so the benchmark can share them.
- A test checks that a loadgen config naming no adapter is rejected.

#### Related issues

- resolves #790

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Pull Request Pull Request #841: [grpc, utils] Size the HTTP/2 flow control windows

Coverage Stats

49 of 49 new or added lines in 7 files covered. (100.0%)

45 existing lines in 10 files now uncovered.

9755 of 10784 relevant lines covered (90.46%)

10098.27 hits per line