hyperledger / fabric-x-committer / 36565007287

91%

Build Type

push

github

Committed by web-flow

Commit Message

[vc, coordinator, sidecar] Verify a checkpoint against the local snapshot hash before committing it (#804)

#### Type of change

- New feature
- Test update
- Documentation update

#### Description

- Add `service/vc/checkpoint.go`: before a `_checkpoint` write commits,
the VC compares the attested hash against the hash it computed for the
referenced snapshot. On a match the attestation commits and the
`_snapshot` record advances to CHECKPOINTED; otherwise the write is
dropped and either the TX is rejected (a snapshot this committer is not
awaiting) or a `CheckpointFeedback` gates block intake — HOLD while the
hash is still computing, HALT when local state contradicts it.
- Reject rather than halt on bad input. `_checkpoint` is
client-submittable, so halting on a checkpoint for a block that was
never snapshotted would let any authorized submitter stop the committer.
Both rejections reuse MALFORMED_CHECKPOINT_INVALID_KEY with a TODO: a
precise REJECTED_CHECKPOINT_NO_SUCH_SNAPSHOT has to land in
fabric-x-common first.
- Advance the record inside the commit transaction
(`statedb.MarkSnapshotCheckpointedInTx`). A second transaction would
leave a crash window where a durable attestation reads to the admission
gate as "still awaiting a checkpoint", rejecting every later snapshot.
Its invariant violations are non-retryable, so the commit retry now
treats ErrNonRetryable as terminal.
- Verify in the validator (`rejectCheckpointIfNotVerified`), which
already holds the database handle; the committer only forwards the
verdict. Report no per-TX status for a held checkpoint: `insertTxStatus`
would make the sidecar's re-submission a duplicate forever, so the
feedback carries the full `TxRef` instead.
- Forward the status-less batch in the coordinator and release the
checkpoint's node explicitly, or the re-delivered checkpoint deadlocks
behind its own stale node. Decrement `numTxsInProgress` for the feedback
via a shared `txCount` helper, or a feedback-only batch le... (continued)

Coverage Stats

214 of 242 new or added lines in 15 files covered. (88.43%)

12 existing lines in 8 files now uncovered.

9764 of 10761 relevant lines covered (90.74%)

10761.03 hits per line