hyperledger / fabric-x-committer / 36686839933

91%

main: 91%

Build Type

Pull #840

github

Committed by liran-funaro

Commit Message

[sidecar] Parse a block's transactions in parallel

#### Type of change

- Improvement (improvement to code, performance, etc)

#### Description

- Splits `mapBlock` into a parallel parse and a serial fold. `parseMessages` parses, classifies
  and validates each message across up to `max-workers-for-tx-parsing` goroutines, each given at
  least `min-tx-parsing-batch-size` messages, and `applyParsedTX` folds the results into the
  block in message order.
- Adds the sidecar `max-workers-for-tx-parsing` (default 1, parsing on one goroutine) and
  `min-tx-parsing-batch-size` (default 256) settings.
- The TX ID dedup set, the one-snapshot-per-block rule and the batch order stay single-threaded,
  so which transactions a block accepts and rejects does not depend on how parsing was split.
- Replaces `mapConfigTx` with `parseConfigTx` and `appendConfigTx`: a config TX is validated in
  the parallel pass, where failing the block is still an option, and appended in the serial one.
- Each parse worker builds its own messages' TxWithRefs in #833's per-block slabs, now allocated in
  `parseMessages`, so the slabs need no locking.

#### Related issues

- resolves #786

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

# Conflicts:
#	cmd/config/samples/sidecar.yaml
#	service/sidecar/relay.go
#	service/sidecar/relay_test.go
#	service/sidecar/sidecar.go

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# interactive rebase in progress; onto b2e37863f
# Last command done (1 command done):
#    pick c99857caf # [sidecar] Parse a block's transactions in parallel
# No commands remaining.
# You are currently rebasing branch 'feat/sidecar-parallel-parse' on 'b2e37863f'.
#
# Changes to be committed:
#	modified:   cmd/config/app_config_test.go
#	modified:   cmd/config/samples/sidecar.yaml
#	modified:   docs/performance-tuning.md
#	modified:   doc... (continued)

Pull Request Pull Request #840: [sidecar] Parse a block's transactions in parallel

Coverage Stats

56 of 64 new or added lines in 3 files covered. (87.5%)

34 existing lines in 8 files now uncovered.

9762 of 10775 relevant lines covered (90.6%)

11654.37 hits per line