hyperledger-labs / fabric-smart-client / 36636093133

92%

Build Type

push

github

Committed by web-flow

Commit Message

test(fabricx): increase coverage of platform/fabricx/core/transaction (#1949)

Cover endorsement with a signer and with a creator identity, the
getProposalResponse error branches, SetFromEnvelopeBytes and
SetFromBytes with signed proposals, NewTransactionFromSignedProposal,
ProposalHasBeenEndorsedBy, the RWSet and transient-store error paths,
the Proposal and Envelope accessors, createSCEnvelope channel errors,
and Envelope/SignedProposal construction, round-tripping and unpacking.

The tests surfaced bugs that are fixed here:
- ProposalHasBeenEndorsedBy panicked on a transaction without a signed
  proposal, in both the Fabric and Fabric-x implementations. It now
  returns an error; each package has a regression test.
- getProposalResponse error messages printed the whole namespace struct
  instead of the namespace ID.

Godoc on SetFromEnvelopeBytes and NewTransactionFromEnvelopeBytes states
that only Fabric endorser transaction envelopes are accepted, which
excludes the HeaderType_MESSAGE envelopes this package produces.

Fixes #1936

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

11 of 12 new or added lines in 2 files covered. (91.67%)

7 existing lines in 4 files now uncovered.

28243 of 32206 relevant lines covered (87.69%)

2291.58 hits per line