solidjs / solid / 36613321307

76%

main: 89%

push

github

reportServerError resolves the error policy from the erroring render, not the global context

`reportServerError` chose the per-request hook as
`hook ?? sharedConfig.context.errorPolicy ?? ambient`. The global is
whichever render touched it last, and a finished `renderToString`
context stays there. So a failure that landed from async work reached
another request's `onError`: that handler received the error with its
details, and its return became the wire value this request's client got.
Every caller that relied on the implicit read leaked:

- a <Loading> boundary failing from its resume loop (`finalizeError`:
  `failed` pre-shell, `client` post-shell)
- the stream serializer's `onError` (`serializerErrorHook`), for a
  hydration value that settles late and will not serialize
- a server function dispatched over HTTP without a handler `onError`
  (the thrown tail and result-graph channels), which reached whatever
  render's hook was lingering
- an in-process server-function call during SSR that rejects late or is
  made after an `await` (`reportDirectFailure`)

`reportServerError` no longer reads the global. Its `hook` argument is
the hook of the render or request the failure belongs to; `undefined`
means the ambient `configureServerErrors` hook answers alone. Callers
pass their own:

- the Loading and Errored boundaries pass the `errorPolicy` of the
  context they captured at creation (`ssrSanitizeError` gains a matching
  optional `hook` parameter for the Errored site)
- `failRender` and the serializer hook pass the renderer's own
  `options.onError`
- HTTP server functions keep their handler hook only
- direct calls use the hook of the render serving the request they are
  made under. `renderToString`/`renderToStream` file their `onError`
  against their request event at start (`request-error-hook.ts`, a
  process-wide WeakMap under a registered symbol, since the
  server-function bundle inlines its own copy of the module). The call
  resolves it fro... (continued)

625 of 912 branches covered (68.53%)

Branch coverage included in aggregate %.

936 of 1186 relevant lines covered (78.92%)

27.2 hits per line