coderaiser / putout-editor / 36606319739

100%

push

github

refactor: plugin-putout-editor: remove-comments is an includer

The rule became include + filter, which is the shape the house docs call an
includer and which the maintainer suggested. It drops the Program visitor and
the raw traverse from the previous commit in favour of naming the node types
by their babel aliases.

include is ['Statement', 'Expression', 'ObjectProperty']. Measured on a file
carrying all ten comment positions: 11 places, 0 comments left after --fix,
the same result the traverse form gave.

The aliases are load-bearing rather than decorative. ['Statement'] alone
reports all ten but leaves the ObjectProperty comment in place, and
['__', 'Statement'] is no better: __ and __a both resolve to Identifier, and an
Identifier never carries a comment - checked against a real file, false. So
the placeholder form reaches nodes that have nothing to find, and it cannot
stand in for the aliases. 'Node' is not a valid include either; babel rejects
it with "You gave us a visitor for the node type Node".

fix takes a bare path here, not the {path, key} a traverse rule gets: the
includer builds its visitor with prePush, which calls push(path), so runFix
hands fix that path. Reading it as {path, key} silently fixed nothing.

172 tests, 100% coverage, putout . clean.

1081 of 1081 branches covered (100.0%)

Branch coverage included in aggregate %.

6670 of 6670 relevant lines covered (100.0%)

61.48 hits per line