coderaiser / putout-editor / 36602086933

100%

push

github

refactor: plugin-putout-editor: remove-comments, Program and the raw traverse

Replaces the seven-name NODES list with a Program visitor that calls the raw
traverse itself, so every node is visited without naming them. Suggested by
the maintainer after I concluded the catch-all did not exist; it does, just
one layer down.

The rule runner drops a top-level `enter`/`exit` on purpose -
@putout/babel's shouldIgnoreKey returns true for both, and merge2 skips those
keys while merging the visitor - so `{enter}` inside a rule's traverse fires
zero times. `Program` is not ignored, and traverse() imported from putout is
the same babel walk estree-to-babel uses, before the merge, so `enter` works
there. That is also why estree-to-babel could get away with it and this rule
could not: two entry points into one library.

Measured head to head on a file carrying all six comment positions: 11 places
and 0 comments left after --fix, identical for both forms. The import is
aliased to babelTraverse because the rule exports its own traverse, and the
unaliased name is a SyntaxError: Identifier 'traverse' has already been
declared.

Kept the three spec cases from the previous commit - they are what proves the
widened shapes, and they would still pass if the walk went back to a list.
172 tests, 100% coverage, putout . clean.

1081 of 1081 branches covered (100.0%)

Branch coverage included in aggregate %.

6670 of 6670 relevant lines covered (100.0%)

61.48 hits per line