coderaiser / putout-editor / 36607671474

100%

push

github

refactor: plugin-putout-editor: remove-comments, no KEYS and no loops

Drops the KEYS array and the two loops over it. The three keys are named
where they are used, so the rule reads top to bottom without indirection:

  const hasLength = (a) => a && a.length;

fix empties all three unconditionally, which is safe because filter has
already established at least one is populated. filter destructures the three
off node in its signature and returns early on the first two.

`return hasLength(innerComments)` rather than `return false` because
return/simplify-boolean rejects the plain false once the earlier returns are
in place, and hasLength already coerces. Optional chaining is out: the
optional-chaining rule bans it here, which is why the condition is
`a && a.length` and not `a?.length`.

Same behaviour, measured after the change: 10 of 10 comments removed by
--fix, 0 places on a clean file, 172 tests, 100% coverage, putout . clean.

1081 of 1081 branches covered (100.0%)

Branch coverage included in aggregate %.

6670 of 6670 relevant lines covered (100.0%)

61.48 hits per line