coderaiser / putout-editor / 36595499280

100%

push

github

refactor: plugin-putout-editor: remove-comments, every node that carries one

The rule visited VariableDeclaration and nothing else, so a comment above a
function, a class, an export, a call, or inside a function body passed
silently - the same redundancy the rule exists to catch, in the positions
nobody had tried. Measured against the AST: comments attach to eleven node
types and the rule was watching one.

Widened to the seven that carry them, built from a NODES list so the visitor
is generated rather than copied seven times. The -fix twin was regenerated by
running the rule, not by hand, and now strips nine comments where it stripped
three.

A catch-all visitor was the obvious shape and it does not exist here: `$`
matches no node and returns zero places, and `*` is parsed as a template
placeholder and throws a BABEL_TEMPLATE_PARSE_ERROR. The mcp traverser
example walks Program and path.get('body') explicitly for the same reason, so
an explicit list is the only form available - which makes NODES a to-do list
rather than a solved problem, and the reason the widened rule now has spec
cases of its own.

Verified it still has teeth: a comment planted at the top of a rule file is
reported, and the old rule would not have seen it. 172 tests, 100% coverage,
putout . clean over the whole repository.

Note for the next reader: UPDATE=1 is destructive here. It deleted four
-fix fixtures belonging to other rules, and emptied this one rather than
regenerating it. The twins were restored with git checkout and the fix
generated by running the rule directly.

1081 of 1081 branches covered (100.0%)

Branch coverage included in aggregate %.

6670 of 6670 relevant lines covered (100.0%)

61.48 hits per line