hyperledger-labs / fabric-smart-client / 36563084612

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(endorser)!: return an error instead of panicking on a nil service provider (#1929)

NewBuilder and NewBuilderWithServiceProvider panicked when given a nil
service provider, so a wiring or setup mistake crashed the process
instead of surfacing as an error. Both constructors now return
(*Builder, error), and the package-level transaction helpers return
that error. The Builder methods also return it when the Builder has no
service provider, which covers a zero-value Builder.

BREAKING CHANGE: endorser.NewBuilder now returns (*Builder, error)
instead of *Builder. Callers must check the error. NewBuilderWithServiceProvider
got removed.

Fixes #1387

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

19 of 25 new or added lines in 1 file covered. (76.0%)

20 existing lines in 7 files now uncovered.

27922 of 32198 relevant lines covered (86.72%)

2774.53 hits per line