hyperledger-labs / fabric-smart-client / 36551184958

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(state)!: return errors instead of panicking from transaction inspection APIs (#1388) (#1928)

endorser.Transaction.Namespaces and state.Namespace's NumInputs, NumOutputs,
Commands, Outputs and Inputs panicked when the RWSet could not be obtained,
a read key or write could not be looked up, or the command header was not
valid JSON. These are data-dependent failures on received transactions, not
internal invariants, so a malformed or unexpected transaction payload
crashed the process instead of surfacing as a recoverable error.

The six methods now return (T, error) and callers handle the error.
Panic-asserting unit tests were rewritten to assert the returned error, and
the integration sample views (iou, atsa, fabricx/simple) were updated to
check it, following each file's existing error-handling idiom.

BREAKING CHANGE: (*endorser.Transaction).Namespaces and
(*state.Namespace).NumInputs, NumOutputs, Commands, Outputs and Inputs now
return (T, error) instead of T. Callers must check the error instead of
relying on a panic to signal a malformed or unreadable transaction.

Closes #1388

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

15 of 15 new or added lines in 2 files covered. (100.0%)

9 existing lines in 3 files now uncovered.

27916 of 32182 relevant lines covered (86.74%)

2332.55 hits per line