coreui / coreui-pro / 36555734511

96%

main: 94%

push

github

fix(SectionInput): drop the submit verdict and restore the created date on a native form reset (#1469)

A native form reset put the initial date back, but it kept the verdict of a submit of a `data-coreui-validate` form: a required empty field stayed `.is-invalid` with `aria-invalid="true"`, and a filled one stayed `.is-valid`. The reset handler now drops that verdict and does nothing when a `reset` listener cancels the event. A submit that follows the reset in the same task judges the restored date; that submit is counted in the capture phase, so a page that resets the form in its own submit listener does not keep the verdict of the submit it resets from.

The reset target is now the date the field was created with. It used to be the validated date, so a field created with a date its limits reject came back empty (measured in Chromium). `reset()` also drops select all. Specs in the date input reset block and the time picker cover each case, and the date input and date range input pages describe the reset. The minified bundles grow by 155 B and 178 B gzip, over their budgets by 30 B and 40 B, so both budgets go up by 0.25 kB.

6272 of 6827 branches covered (91.87%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 1 file covered. (100.0%)

11339 of 11656 relevant lines covered (97.28%)

862.84 hits per line