hyperledger-labs / fabric-smart-client / 36543371693
92%

DEFAULT BRANCH: main
Ran
Jobs 22
Files 503
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.521% (+0.03%) from 86.49%
36543371693

push

github

web-flow 
fix(integration): guard unguarded X(...)[0] indexing in the nwo test harness (#1923)

Several call sites read the first element of a platform/peer/org lookup
without checking that the collection was non-empty, or type-asserted a
platform without checking the assertion. On an unexpected topology (e.g.
a peer org with no peers, or no fabric/fsc platform registered) these
panicked with a generic "index out of range" or interface-conversion
message instead of a clear test failure explaining what was expected.

Guard each site with the gomega.Expect(...).To(gomega.HaveLen(1)) /
ok-checked type-assertion idiom already used in
integration/fabric/configupdate/configupdate.go, so a violated
invariant fails the spec with a descriptive message:

- integration/integration.go: ViewCmd's fsc platform lookup
- integration/fabric/runtimeconfig/commands.go: InjectAll's fabric
  platform lookup
- integration/nwo/fabric/platform.go: UserByOrg, UsersByOrg,
  InvokeChaincode and ConnectionProfile's peer/org lookups
- integration/nwo/monitoring/monitoring/monitoring.go: fscScrapes and
  fscCryptoDir's fsc platform lookup

Document when each guarded function fails the test, and add unit tests
exercising both the happy path and the guard panics in platform.go and
monitoring.go. Tests use only testify/require in their bodies; a
package-level TestMain registers gomega's fail handler to panic
(mirroring integration.go's Ginkgo setup) so the guarded gomega.Expect
calls raise a catchable panic under go test.

Fixes #1918

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

27833 of 32169 relevant lines covered (86.52%)

2326.43 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
96.72
-3.28% platform/common/utils/lazy/provider.go
2
76.83
-0.61% platform/fabric/core/generic/msp/idemix/provider.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabric-configupdate - 36543371693.1 459
38.8
GitHub Action Run
2 utest-extensions - 36543371693.2 8
52.57
GitHub Action Run
3 itest-fabric-twonets - 36543371693.3 449
29.22
GitHub Action Run
4 itest-fabric-iouhsm - 36543371693.4 459
39.71
GitHub Action Run
5 itest-fabric-iou-libp2p - 36543371693.5 459
36.52
GitHub Action Run
6 itest-fabricx-deployment - 36543371693.6 481
28.32
GitHub Action Run
7 itest-fsc-pingpong - 36543371693.7 245
34.6
GitHub Action Run
8 itest-fabricx-multiendorsement - 36543371693.8 481
28.4
GitHub Action Run
9 utest-postgres - 36543371693.9 494
9.72
GitHub Action Run
10 itest-fabric-runtimeconfig - 36543371693.10 459
38.81
GitHub Action Run
11 itest-fabricx-configupdate - 36543371693.11 481
28.35
GitHub Action Run
12 itest-fsc-signedpingpong - 36543371693.12 240
31.54
GitHub Action Run
13 itest-fabric-atsa - 36543371693.13 449
43.59
GitHub Action Run
14 itest-fabricx-atsa - 36543371693.14 481
30.52
GitHub Action Run
15 utest-root - 36543371693.15 494
83.49
GitHub Action Run
16 itest-fabricx-simple - 36543371693.16 481
27.78
GitHub Action Run
17 itest-fabric-iou - 36543371693.17 459
40.35
GitHub Action Run
18 itest-fabricx-iou - 36543371693.18 481
29.19
GitHub Action Run
19 itest-fabric-stoprestart - 36543371693.19 449
31.21
GitHub Action Run
20 itest-fabric-events - 36543371693.20 454
29.01
GitHub Action Run
21 itest-fsc-stoprestart - 36543371693.21 241
33.45
GitHub Action Run
22 itest-fabric-atsachaincode - 36543371693.22 454
30.89
GitHub Action Run
Source Files on build 36543371693